lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <41840b750608070813s6d3ffc2enefd79953e0b55caa@mail.gmail.com>
Date:	Mon, 7 Aug 2006 18:13:06 +0300
From:	"Shem Multinymous" <multinymous@...il.com>
To:	"Pavel Machek" <pavel@...e.cz>
Cc:	"Robert Love" <rlove@...ve.org>,
	"Jean Delvare" <khali@...ux-fr.org>,
	"Greg Kroah-Hartman" <gregkh@...e.de>,
	"Alan Cox" <alan@...rguk.ukuu.org.uk>,
	linux-kernel@...r.kernel.org, hdaps-devel@...ts.sourceforge.net
Subject: Re: [PATCH 01/12] thinkpad_ec: New driver for ThinkPad embedded controller access

Hi Pavel,

Thanks for the sign-offs!

On 8/7/06, Pavel Machek <pavel@...e.cz> wrote:
> > +module_param_named(debug, tp_debug, int, 0600);
> > +MODULE_PARM_DESC(debug, "Debug level (0=off, 1=on)");
> > +
> > +/* A few macros for printk()ing: */
> > +#define DPRINTK(fmt, args...) \
> > +  do { if (tp_debug) printk(KERN_DEBUG fmt, ## args); } while (0)
>
> Is not there generic function doing this?

None that I found. Many drivers do it this way.


> > +EXPORT_SYMBOL_GPL(thinkpad_ec_lock);
> > +EXPORT_SYMBOL_GPL(thinkpad_ec_try_lock);
> > +void thinkpad_ec_unlock(void)
> > +{
> > +     up(&thinkpad_ec_mutex);
> > +}
> > +
>
> Do we need these wrappers? Perhaps just directly exporting the mutex?

Yes, we may end up needing to lock away other systems (ACPI?) that
touch the same ports. Apparently not an issue right now, but could
change with new firmware.
Also, that's what Alan Cox told me to do. :-)



> > +     for (i=0; i<TPC_REQUEST_RETRIES; ++i) {
>
> I'd write i++ here (and in other loops)... just for consistency with
> rest of kernel.

OK.
"++i" is the recommended form for C++, got used to that.


> > +     struct dmi_device *dev = NULL;
>
> unneeded initializer.

On a local variable?!


> > +static int __init thinkpad_ec_init(void)
> > +{
> > +     if (!check_dmi_for_ec()) {
> > +             printk(KERN_ERR "thinkpad_ec: no ThinkPad embedded controller!\n");
> > +             return -ENODEV;
>
> KERN_ERR is little strong here, no?

Not sure what's the right one. The user tried to load a module and the
module can't do that; I saw some drivers use KERN_ERR some
KERN_WARNING in similar cases. Is there some guideline on choosing
printk levels?

OK on all other points.

  Shem
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ