lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20060807081519.945df808.akpm@osdl.org>
Date:	Mon, 7 Aug 2006 08:15:19 -0700
From:	Andrew Morton <akpm@...l.org>
To:	Andy Whitcroft <apw@...dowen.org>
Cc:	Andi Kleen <ak@...e.de>, linux-kernel@...r.kernel.org
Subject: Re: x86_64 command line truncated

On Mon, 07 Aug 2006 15:38:49 +0100
Andy Whitcroft <apw@...dowen.org> wrote:

> Andi Kleen wrote:
> > Andy Whitcroft <apw@...dowen.org> writes:
> > 
> >> It seems that the command line on x86_64 is being truncated during boot:
> > 
> > in mm right?
> >> Will try and track it down.
> > 
> > Don't bother, it is likely "early-param" (the patch from
> > hell). I'll investigate.
> > 
> > -Andi
> 
> Well I've narroed it down to the following patch from Andrew:
> 
> x86_64-mm-early-param.patch

Not me.  My only contribution to that patch was to scrog the changelog ;)
I'll be fixing that sometime.

I think that patch doesn't have a future, although Andi hasn't yet dropped it.

> Basically, that leads setup_arch to return saved_command_line as _the_ 
> command_line.  We then run parse_args() against it which assumes it may 
> irrevocabaly change command_line.  Previous to this patch 
> saved_command_line and command_line were separate and this was not an issue.
> 
> It feels like we should be following the model in the newly added 
> parse_early_parms() and taking a local copy of the command_line here.
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ