linux-kernel - Re: How to lock current->signal->tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 08 Aug 2006 08:10:51 -0700
From:	Arjan van de Ven <arjan@...ux.intel.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	linux-kernel@...r.kernel.org, davem@...hat.com, sds@...ho.nsa.gov,
	jack@...e.cz, dwmw2@...radead.org, tony.luck@...el.com,
	jdike@...aya.com, James.Bottomley@...senPartnership.com
Subject: Re: How to lock current->signal->tty

Alan Cox wrote:
> The biggest crawly horror I've found so far in auditing the tty locking
> is current->signal->tty. The tty layer currently and explicitly protects
> this using tty_mutex. The core kernel likewise knows about this.
> 
> Unfortunately:
> 	Dquot passes the tty to tty_write_message without locking
> 	arch/ia64/kernel/unanligned seems to write to it without locking

these two have absolutely no business at all using anything tty.... they should
just use printk with KERN_EMERG or whatever
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/