linux-kernel - Re: [PATCH] copy_process: cosmetic ->ioprio tweak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20060821143224.62018aba.akpm@osdl.org>
Date:	Mon, 21 Aug 2006 14:32:24 -0700
From:	Andrew Morton <akpm@...l.org>
To:	Oleg Nesterov <oleg@...sign.ru>
Cc:	Jens Axboe <axboe@...e.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] copy_process: cosmetic ->ioprio tweak

On Sun, 20 Aug 2006 18:53:21 +0400
Oleg Nesterov <oleg@...sign.ru> wrote:

> copy_process:
> // holds tasklist_lock + ->siglock
>        /*
>         * inherit ioprio
>         */
>        p->ioprio = current->ioprio;
> 
> Why? ->ioprio was already copied in dup_task_struct().

It might just be a thinko.

> I guess this is needed
> to ensure that the child can't escape sys_ioprio_set(IOPRIO_WHO_{PGRP,USER}),
> yes?

How could the child escape that if this assignment was not present?

> In that case we don't need ->siglock held, and the comment should be updated.

Surely.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/