linux-kernel - Re: [RFC][PATCH] ps command race fix take2 [3/4] profile fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <p737j1181tq.fsf@verdi.suse.de>
Date:	22 Aug 2006 13:08:49 +0200
From:	Andi Kleen <ak@...e.de>
To:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Cc:	Andrew Morton <akpm@...l.org>, ebiederm@...ssion.com, pj@....com,
	saito.tadashi@...t.fujitsu.com, linux-kernel@...r.kernel.org
Subject: Re: [RFC][PATCH] ps command race fix take2 [3/4] profile fix

KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> writes:

> ===================================================================
> --- linux-2.6.18-rc4.orig/include/linux/sched.h
> +++ linux-2.6.18-rc4/include/linux/sched.h
> @@ -808,6 +808,10 @@ struct task_struct {
>  	struct list_head ptrace_children;
>  	struct list_head ptrace_list;
>  
> +#if defined(CONFIG_OPROFILE) || defined(CONFIG_OPROFILE_MODULE)
> +	struct list_head 	dead_tasks;
> +#endif

Sorry I think this needs a cleaner solution without ifdef.   Why can't it use
the token list? Or some other list head that's unused then.

Otherwise I would think it it better to use a separate list object to
maintain this list in oprofile.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/