linux-kernel - Re: [RFC][PATCH] ps command race fix take2 [3/4] profile fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20060822202810.30bfdb60.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Tue, 22 Aug 2006 20:28:10 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	Andi Kleen <ak@...e.de>
Cc:	akpm@...l.org, ebiederm@...ssion.com, pj@....com,
	saito.tadashi@...t.fujitsu.com, linux-kernel@...r.kernel.org
Subject: Re: [RFC][PATCH] ps command race fix take2 [3/4] profile fix

On 22 Aug 2006 13:08:49 +0200
Andi Kleen <ak@...e.de> wrote:

> KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> writes:
> 
> > ===================================================================
> > --- linux-2.6.18-rc4.orig/include/linux/sched.h
> > +++ linux-2.6.18-rc4/include/linux/sched.h
> > @@ -808,6 +808,10 @@ struct task_struct {
> >  	struct list_head ptrace_children;
> >  	struct list_head ptrace_list;
> >  
> > +#if defined(CONFIG_OPROFILE) || defined(CONFIG_OPROFILE_MODULE)
> > +	struct list_head 	dead_tasks;
> > +#endif
> 
> Sorry I think this needs a cleaner solution without ifdef.   Why can't it use
> the token list? Or some other list head that's unused then.
> 

I added them because oprofile doesn't need tokened-list. But adding new
member only for this seems a bit expensive as you point out.
I'll find another way, reuse some list_head or use tokened-list.

-Kame

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/