linux-kernel - Re: [RFC][PATCH] ps command race fix take2 [1/4] list token

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20060822202350.35be06fc.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Tue, 22 Aug 2006 20:23:50 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	Andi Kleen <ak@...e.de>
Cc:	akpm@...l.org, ebiederm@...ssion.com, pj@....com,
	saito.tadashi@...t.fujitsu.com, linux-kernel@...r.kernel.org
Subject: Re: [RFC][PATCH] ps command race fix take2 [1/4] list token

On 22 Aug 2006 13:06:34 +0200
Andi Kleen <ak@...e.de> wrote:

> KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com> writes:
> > 
> > listtoken , a helper for walking a list by intermittent access.
> > 
> > When we walk a list intermittently and the list is being modified at the
> > same time, it's hard to remember our position in it.
> > 
> > With this list token, a user can remember where he is reading by inserting
> > a token in the list.
> 
> I think the header/code needs much more comments so that other people
> can still make sense of it later. Even with the commit log it's not
> quite clear how it works.
> 
Okay, make them more informative.

> Also locking needs to be explained. 
Yes, with RCU. we need appropriate lock.

> I suppose only one user is allowed to use a token at one time?
> 
Yes, I expext that a user uses a token. But several tokens can be inserted to a list.

> But overall it's a good idea to have a generic facility like this.
> I suppose it will be a more common problem in the future.
> 

Thanks,
-Kame

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/