linux-kernel - [PATCH] x86_64: mm fix x86 cpuid keys used in alternative

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 24 Aug 2006 03:58:46 -0700
From:	Paul Jackson <pj@....com>
To:	Andrew Morton <akpm@...l.org>
Cc:	Jan Beulich <jbeulich@...ell.com>, Paul Jackson <pj@....com>,
	linux-kernel@...r.kernel.org, Andi Kleen <ak@...e.de>
Subject: [PATCH] x86_64: mm fix x86 cpuid keys used in alternative_smp fix

From: Paul Jackson <pj@....com>

The x86_64 crosstool build was failing due to:

  kernel/built-in.o(.smp_altinstructions+0x58): \
    include/asm/spinlock.h:54: undefined reference to `X86_FEATURE_UP'

This reference to X86_FEATURE_UP was added to the definition of
the alternative_smp() macro in alternative.h by the patch:
  x86_64-mm-fix-x86-cpuid-keys-used-in-alternative_smp

The alternative_smp() macro is used in spinlock.h.

The definition of X86_FEATURE_UP is in asm-x86_64/cpufeature.h.
If this is included in alternative.h, then the build succeeds.

Signed-off-by: Paul Jackson <pj@....com>

---

 include/asm-x86_64/alternative.h |    1 +
 1 files changed, 1 insertion(+)

--- 2.6.18-rc4-mm2.orig/include/asm-x86_64/alternative.h	2006-08-24 03:37:22.000000000 -0700
+++ 2.6.18-rc4-mm2/include/asm-x86_64/alternative.h	2006-08-24 03:38:09.000000000 -0700
@@ -4,6 +4,7 @@
 #ifdef __KERNEL__
 
 #include <linux/types.h>
+#include <asm/cpufeature.h>
 
 struct alt_instr {
 	u8 *instr; 		/* original instruction */

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@....com> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/