linux-kernel - Re: [RFC][PATCH] Manage jbd allocations from its own slabs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060824185342.GA20935@infradead.org>
Date:	Thu, 24 Aug 2006 19:53:42 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	Badari Pulavarty <pbadari@...ibm.com>
Cc:	Herbert Xu <herbert@...dor.apana.org.au>, akpm@...l.org,
	lkml <linux-kernel@...r.kernel.org>,
	ext2-devel <Ext2-devel@...ts.sourceforge.net>
Subject: Re: [RFC][PATCH] Manage jbd allocations from its own slabs

On Wed, Aug 23, 2006 at 04:08:15PM -0700, Badari Pulavarty wrote:
> Hi,
> 
> Here is the fix to "bh: Ensure bh fits within a page" problem
> caused by JBD.
> 
> BTW, I realized that this problem can happen only with 1k, 2k
> filesystems - as 4k, 8k allocations disable slab debug 
> automatically. But for completeness, I created slabs for those
> also.
> 
> What do you think ? I ran basic tests and things are fine.

Why can't you just use alloc_page?  I bet the whole slab overhead
eats more memory than what's wasted when using alloc_pages.  Especially
as the typical usecase is a 4k blocks filesystem with 4k pagesize
where the overhead of alloc_page is non-existant.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/