linux-kernel - Re: [PATCH] boot: small change of halt method

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44EDF923.4030607@zytor.com>
Date:	Thu, 24 Aug 2006 12:08:19 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Andrew Brukhov <pingved@...il.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] boot: small change of halt method

Andrew Brukhov wrote:
> I'm new here.
> After reading boot code i'm immidiatly change this string:
> 
> --- ./linux-2.6.17.11/arch/i386/boot/compressed/misc.c	2006-08-24 01:16:33.000000000 +0400
> +++ /usr/src/linux-2.6.17.11/arch/i386/boot/compressed/misc.c	2006-08-24 22:36:10.000000000 +0400
> @@ -7,6 +7,7 @@
>   * malloc by Hannu Savolainen 1993 and Matthias Urlichs 1994
>   * puts by Nick Holloway 1993, better puts by Martin Mares 1995
>   * High loaded stuff by Hans Lermen & Werner Almesberger, Feb. 1996
> + * Small fix of halt method Andrew Brukhov, Aug. 2006               
>   */
>  
>  #include <linux/linkage.h>
> @@ -289,8 +290,7 @@ static void error(char *x)
>  	putstr("\n\n");
>  	putstr(x);
>  	putstr("\n\n -- System halted");
> -
> -	while(1);	/* Halt */
> +      	asm( "hlt" );
>  }
> 
> It's becouse this code is platform depended and therefore there is no resons to write infinity cycle.
> 

Wrong.

You need to:

	while (1)
		asm volatile("hlt");

... since HLT only pauses until interrupt.

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/