linux-kernel - Re: [PATCH] exit_io_context: don't disable irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20060829071429.GQ30609@kernel.dk>
Date:	Tue, 29 Aug 2006 09:14:29 +0200
From:	Jens Axboe <axboe@...nel.dk>
To:	Oleg Nesterov <oleg@...sign.ru>
Cc:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] exit_io_context: don't disable irqs

On Sun, Aug 27 2006, Oleg Nesterov wrote:
> We don't need to disable irqs to clear current->io_context, it is
> protected by ->alloc_lock. Even IF it was possible to submit I/O from
> IRQ on behalf of current this irq_disable() can't help:
> current_io_context() will re-instantiate ->io_context after
> irq_enable().
> 
> We don't need task_lock() or local_irq_disable() to clear ioc->task.
> This can't prevent other CPUs from playing with our io_context anyway.
> 
> Signed-off-by: Oleg Nesterov <oleg@...sign.ru>

Applied, thanks.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/