linux-kernel - Re: [PATCH RESEND] sys_ioprio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20060829071630.GR30609@kernel.dk>
Date:	Tue, 29 Aug 2006 09:16:30 +0200
From:	Jens Axboe <axboe@...nel.dk>
To:	Oleg Nesterov <oleg@...sign.ru>
Cc:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] sys_ioprio_set: don't disable irqs

On Sun, Aug 27 2006, Oleg Nesterov wrote:
> It is not good to disable interrupts while traversing all tasks in the system.
> As I see it, sys_ioprio_get() doesn't need to do it at all, sys_ioprio_set()
> does it for cfq_ioc_set_ioprio(), the latter can disable irqs itself.
> 
> Also, add a comment to explain why do we need tasklist_lock.
> 
> Signed-off-by: Oleg Nesterov <oleg@...sign.ru>

You should work against the 'block' branch in the block git repo, things
tend to change... I've applied your ioprio.c bit, the other one is not
needed anymore.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/