[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1157124802.21733.16.camel@localhost>
Date: Fri, 01 Sep 2006 17:33:22 +0200
From: Martin Schwidefsky <schwidefsky@...ibm.com>
To: Dave Hansen <haveblue@...ibm.com>
Cc: linux-kernel@...r.kernel.org, virtualization@...ts.osdl.org,
akpm@...l.org, nickpiggin@...oo.com.au, frankeh@...son.ibm.com,
rhim@...gateh.edu
Subject: Re: [patch 4/9] Guest page hinting: volatile swap cache.
On Fri, 2006-09-01 at 07:58 -0700, Dave Hansen wrote:
> > +#if defined(CONFIG_PAGE_STATES)
>
> This is a bit odd. Why not use an #ifdef like the rest of the kernel?
Personal preference I guess. If you have multiple macros you want to
test for you need to use "#if defined(a) && defined(b)", there is no
equivalent #ifndef notation.
--
blue skies,
Martin.
Martin Schwidefsky
Linux for zSeries Development & Services
IBM Deutschland Entwicklung GmbH
"Reality continues to ruin my life." - Calvin.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists