linux-kernel - Re: [PATCH 03/16] GFS2: bmap and inode functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060902162547.GA23962@elte.hu>
Date:	Sat, 2 Sep 2006 18:25:47 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
Cc:	Steven Whitehouse <swhiteho@...hat.com>,
	linux-kernel@...r.kernel.org,
	Russell Cattelan <cattelan@...hat.com>,
	David Teigland <teigland@...hat.com>, hch@...radead.org
Subject: Re: [PATCH 03/16] GFS2: bmap and inode functions


* Ingo Molnar <mingo@...e.hu> wrote:

> > >> How about inverting the if() to:
> > >> 
> > >> 	if(ip == NULL)
> > >> 		return;
> > >> 	if(test_bit(GLF_DIRTY, &gl->gl_flags))
> > >> 		gfs_inode_attr_in(ip);
> > >> 	gfs2_meta_cache_flush(ip);
> > >
> > >btw., it should be "if (", not "if(".
> > 
> > There is no such rule in CodingStyle.
> 
> still it's part of the proper coding style :)

btw., it is in CodingStyle too:

 $ egrep 'if.*\(' Documentation/CodingStyle

        if (condition) do_this;
        if (condition)
        if (x is true) {
        if (x == y) {
        } else if (x > y) {
        if (buffer == NULL)
        if (condition1) {
                if (a == 5)                     \
                if (blah(x) < 0)                \

	Ingo

-- 
VGER BF report: H 1.87073e-14
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/