linux-kernel - Re: [PATCH 08/22][RFC] Unionfs: Directory manipulation helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <44FBD462.1040902@goop.org>
Date:	Mon, 04 Sep 2006 00:23:14 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
CC:	Josef Sipek <jsipek@...sunysb.edu>, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, hch@...radead.org, akpm@...l.org,
	viro@....linux.org.uk
Subject: Re: [PATCH 08/22][RFC] Unionfs: Directory manipulation helper functions

Jan Engelhardt wrote:
>> +	if (0 <= bopaque && bopaque < bend)
>>     
>
> Turn it. Constant values are usually wanted on the right side.
>
> 	bopaque >= 0

Not in this case.  The test in its current form clearly shows that 
bopaque needs to be within a range.


    J

-- 
VGER BF report: H 0
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/