linux-kernel - Re: [PATCH 11/22][RFC] Unionfs: Lookup helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.61.0609040918350.9108@yvahk01.tjqt.qr>
Date:	Mon, 4 Sep 2006 09:24:42 +0200 (MEST)
From:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
To:	Josef Sipek <jsipek@...sunysb.edu>
cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	hch@...radead.org, akpm@...l.org, viro@....linux.org.uk
Subject: Re: [PATCH 11/22][RFC] Unionfs: Lookup helper functions


>+		if ((bopaque != -1) && (bopaque < bend))

>+	/* If we've only got negative dentries, then use the leftmost one. */
>+	if (lookupmode == INTERPOSE_REVAL) {
>+		if (dentry->d_inode) {
>+			itopd(dentry->d_inode)->uii_stale = 1;
>+		}
>+		goto out;
>+	}
>+		if (!newsize || ((oldsize < newsize) && (newsize > minsize))) {

Some places where -() and -{}

>+static int is_opaque_dir(struct dentry *dentry, int bindex)
>+{
>+	int err = 0;
>+	/* This is an opaque dir iff wh_hidden_dentry is positive */
>+	err = !!wh_hidden_dentry->d_inode;
>+out:
>+	return err;
>+}

This smells like a bool function. If so, don't call it "err" (since boolean
functions do not return "errors").



Jan Engelhardt
-- 

-- 
VGER BF report: H 8.44923e-11
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/