linux-kernel - Re: Re: [patch 6/6] process filtering for fault-injection capabilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1157696997.9460.99.camel@localhost.localdomain>
Date:	Thu, 07 Sep 2006 23:29:57 -0700
From:	Don Mullis <dwm@...r.net>
To:	lkml <linux-kernel@...r.kernel.org>
Cc:	Akinobu Mita <mita@...aclelinux.com>
Subject: Re: Re: [patch 6/6] process filtering for fault-injection
	capabilities

Suggested changes, implemented by patch below:

1) Reorder kernel command line args alphabetically -- lets
output of `ls /debug/failslab` serve as a handy reminder
of the arg bindings.

2) Rename a variable to agree with the /debug file name.

---
 lib/should_fail.c |   14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

Index: linux-2.6.17/lib/should_fail.c
===================================================================
--- linux-2.6.17.orig/lib/should_fail.c
+++ linux-2.6.17/lib/should_fail.c
@@ -13,18 +13,20 @@ int setup_should_fail(struct should_fail
 	unsigned long interval;
 	int times;
 	int space;
-	unsigned long filter;
+	unsigned long process_filter;
 
-	/* "<probability>,<interval>,<times>,<space>,<process-filter>" */
-	if (sscanf(str, "%lu,%lu,%d,%d,%lu", &probability, &interval, &times,
-		   &space, &filter) < 5)
-		return 0;
+	/* "<interval>,<probability>,<process-filter>,<space>,<times>" */
+	if (sscanf(str, "%lu,%lu,%lu,%d,%d", &interval,
+		   &probability, &process_filter, &space, &times) < 5) {
+		printk( "SHOULD_FAIL: failed to parse arguments\n");
+  		return 0;
+	}
 
 	data->probability = probability;
 	data->interval = interval;
 	atomic_set(&data->times, times);
 	atomic_set(&data->space, space);
-	data->process_filter = filter;
+	data->process_filter = process_filter;
 
 	return 1;
 }


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/