linux-kernel - Re: [PATCH 1/5] proc: Make the generation of the self symlink table driven.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 8 Sep 2006 09:07:01 +0200 (MEST)
From:	Jan Engelhardt <jengelh@...ux01.gwdg.de>
To:	Andrew Morton <akpm@...l.org>
cc:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] proc: Make the generation of the self symlink table
 driven.


>> +static struct pid_entry proc_base_stuff[] = {
>> +	NOD(PROC_TGID_INO, 	"self", S_IFLNK|S_IRWXUGO,
>> +		&proc_self_inode_operations, NULL, {}),
>> +	{}
>> +};
>
>We could save a bunch of bytes here.
>
>> +	/* Lookup the directory entry */
>> +	for (p = proc_base_stuff; p->name; p++) {
>
>By using ARRAY_SIZE here.
>
>> +	for (; nr < (ARRAY_SIZE(proc_base_stuff) - 1); filp->f_pos++, nr++) {
>
>like that does.

Also works without the () around ARRAY_SIZE(..)-1



Jan Engelhardt
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/