linux-kernel - Re: [PATCH libata-dev#upstream-fixes] libata: ignore CFA signature while sanity-checking an ATAPI device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45012222.20205@gmail.com>
Date:	Fri, 08 Sep 2006 09:56:18 +0200
From:	Tejun Heo <htejun@...il.com>
To:	Jeff Garzik <jgarzik@...ox.com>
CC:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	"J.A. Magallon" <jamagallon@....com>
Subject: Re: [PATCH libata-dev#upstream-fixes] libata: ignore CFA signature
 while sanity-checking an ATAPI device

Jeff Garzik wrote:
> Andrew Morton wrote:
>> You mean 2.6.18, yes?
> 
> Actually, it looks like it should indeed be 2.6.19 (libata #upstream), 
> not 2.6.18 (libata #upstream-fixes).  Alan's "add compactflash support" 
> patch isn't in 2.6.18-rc.
> 
> So, this should -not- be sent for 2.6.18.

Hello,

Yes, I meant .18.  Jeff, this should be fixed before 2.6.18 is released. 
  It's not the question of whether CFA support is implemented or not. 
We're sanity-checking in 2.6.18-rcX anyway and it's the sanity checking 
which is causing problem.  What seems to have happened is...

1. CFA support is implemented
2. CFA check was added (backported) to upstream-fixes, but it was incorrect.

So, we need to do one of two things.

* apply this patch to 2.6.18-rcX
* remove ata_id_is_cfa() check altogether

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/