linux-kernel - Re: [PATCH RFC]: New termios take 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 10 Sep 2006 14:06:29 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH RFC]: New termios take 2

On Sun, 2006-09-10 at 13:24 +0100, Alan Cox wrote:
> glibc needs them, nobody else does.
> 
> The point I was trying to make is that user space (except glibc) does
> not use them. glibc presents a different struct termios to them already,
> and it always includes c_ispeed/c_ospeed.

That's not the point. The question is what glibc's _implementation_ uses
for doing the ioctls. It has to have _some_ definition of the kernel's
version of the structure.

In fact it seems to have its own 'kernel_termios.h' which is an old copy
of our headers. So in that case, we really can drop <asm/termios.h> from
the export -- as least as far as glibc is concerned. I'm not sure about
other C libraries.

On the other hand, the kind of change you're making is an example of why
we might want glibc to be using a _sanely_ exported copy of our headers
directly, rather than an out-of-date version of its own. But that's a
policy decision I'll leave to you. 

If you want to declare that asm/termios.h isn't to be exported even for
glibc builds then please drop all __KERNEL__ from it and remove it from
include/asm-generic/Kbuild.asm so that it isn't exported.

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/