linux-kernel - Re: [PATCH] piix: Use refcounted interface when searching for a 450NX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Sep 2006 15:44:37 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Sergei Shtylyov <sshtylyov@...mvista.com>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org,
	linux-ide@...r.kernel.org
Subject: Re: [PATCH] piix: Use refcounted interface when searching for a
	450NX

Ar Gwe, 2006-09-15 am 18:14 +0400, ysgrifennodd Sergei Shtylyov:
> > -	while((pdev=pci_find_device(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82454NX, pdev))!=NULL)
> > +	while((pdev=pci_get_device(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_82454NX, pdev))!=NULL)
> >  	{
> >  		/* Look for 450NX PXB. Check for problem configurations
> >  		   A PCI quirk checks bit 6 already */
> 
>     Shouldn't pci_put_dev() be called after the bridge device no longer needed?
> I assume it's not needed anymore after this function is finished...

pci_get_device gets called repeatedly to walk each device. Each call
drops the reference to the previous device (the one passed in).


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/