linux-kernel - Re: [PATCH 5/7] Alter get_order() so that it can make use of ilog2() on a constant [try #3]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Sep 2006 15:42:42 +0100
From:	David Howells <dhowells@...hat.com>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	David Howells <dhowells@...hat.com>, torvalds@...l.org,
	akpm@...l.org, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org
Subject: Re: [PATCH 5/7] Alter get_order() so that it can make use of ilog2() on a constant [try #3] 

Stephen Rothwell <sfr@...b.auug.org.au> wrote:

> Except the get_order() interface is purely related to pages (the fact
> that you have reimplemented it using the log2-based functions is just an
> implementation detail.

Do you have a major objection to it moving to linux/log2.h (do you count the
one you've just raised as "major")?

I'd rather avoid including linux/log2.h or linux/kernel.h in asm/page.h, plus
asm-generic/page.h isn't used by all archs (though that's a minor point).

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/