lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 17 Sep 2006 20:04:51 +1000 From: Stephen Rothwell <sfr@...b.auug.org.au> To: David Howells <dhowells@...hat.com> Cc: torvalds@...l.org, akpm@...l.org, linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org Subject: Re: [PATCH 5/7] Alter get_order() so that it can make use of ilog2() on a constant [try #3] On Fri, 15 Sep 2006 15:42:42 +0100 David Howells <dhowells@...hat.com> wrote: > > Stephen Rothwell <sfr@...b.auug.org.au> wrote: > > > Except the get_order() interface is purely related to pages (the fact > > that you have reimplemented it using the log2-based functions is just an > > implementation detail. > > Do you have a major objection to it moving to linux/log2.h (do you count the > one you've just raised as "major")? I just think that things should be grouped according to the function they provide (and not their implemetation) and get_order is part of the paging API. > I'd rather avoid including linux/log2.h or linux/kernel.h in asm/page.h, plus > asm-generic/page.h isn't used by all archs (though that's a minor point). You only have to include linux/log2.h in asm-generic/page.h. Presumably the architectures that don't use asm-generic/page.h won't want the new implementation of get_order() either (I didn't keep the original patch). Won't you need to include linux/log2.h in some places to get get_order(), now? And if I was needing the paging API, I am much more likely to look for it in {linux,asm}/page.h than in linux/log2.h. -- Cheers, Stephen Rothwell sfr@...b.auug.org.au http://www.canb.auug.org.au/~sfr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists