linux-kernel - Re: [Patch03/05]- Containers: Initialization and Configfs interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1158338846.12311.30.camel@galaxy.corp.google.com>
Date:	Fri, 15 Sep 2006 09:47:26 -0700
From:	Rohit Seth <rohitseth@...gle.com>
To:	Björn Steinbrink <B.Steinbrink@....de>
Cc:	Andrew Morton <akpm@...l.org>, devel@...nvz.org,
	CKRM-Tech <ckrm-tech@...ts.sourceforge.net>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [Patch03/05]- Containers: Initialization and Configfs interface

On Fri, 2006-09-15 at 18:30 +0200, Björn Steinbrink wrote:
> On 2006.09.14 18:41:26 -0700, Rohit Seth wrote:
> > +static int __init configfs_container_init(void)
> > +{
> > +	int ret;
> > +
> > +	config_group_init(&containerfs_group.cs_subsys.su_group);
> > +	init_MUTEX(&containerfs_group.cs_subsys.su_sem);
> > +	ret = configfs_register_subsystem(&containerfs_group.cs_subsys);
> > +
> > +	if (ret) 
> > +		printk(KERN_ERR "Error %d while registering container subsystem\n", ret);
> > +	else {
> > +		container_wq = create_workqueue("Kcontainerd");
> > +		if (container_wq == NULL) {
> > +			ret = -ENOMEM;
> > +			printk(KERN_ERR "Unable to create Container controllers");
> 
> Shouldn't the subsystem be unregistered here?
> 

Yes. Indeed.  I'll fix it.

Thanks,
-rohit

> > +		}
> > +	}
> > +	return ret;
> > +}
> 
> Regards,
> Björn

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/