linux-kernel - RE: [PATCH] SCSI: Make megaraid_ioctl() check copy_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <890BF3111FB9484E9526987D912B261932E37D@NAMAIL3.ad.lsil.com>
Date:	Fri, 15 Sep 2006 12:26:43 -0600
From:	"Ju, Seokmann" <Seokmann.Ju@...l.com>
To:	"Jesper Juhl" <jesper.juhl@...il.com>,
	<linux-kernel@...r.kernel.org>
Cc:	"Kolli, Neela" <Neela.Kolli@...enio.com>,
	<linux-scsi@...r.kernel.org>, <akpm@...l.org>,
	<James.Bottomley@...eleye.com>
Subject: RE: [PATCH] SCSI: Make megaraid_ioctl() check copy_to_user() return value

Hi,

On Friday, September 15, 2006 8:43 AM, Jesper Juhl wrote:
> Check copy_to_user() return value in 
> drivers/scsi/megaraid.c::megadev_ioctl()
> This gets rid of this little warning:
>   drivers/scsi/megaraid.c:3661: warning: ignoring return 
> value of 'copy_to_user', declared with attribute warn_unused_result
ACK - Thank you for correction, Jesper. 

Seokmann

> -----Original Message-----
> From: Jesper Juhl [mailto:jesper.juhl@...il.com] 
> Sent: Friday, September 15, 2006 8:43 AM
> To: linux-kernel@...r.kernel.org
> Cc: Ju, Seokmann; Kolli, Neela; linux-scsi@...r.kernel.org; 
> akpm@...l.org; James.Bottomley@...eleye.com; jesper.juhl@...il.com
> Subject: [PATCH] SCSI: Make megaraid_ioctl() check 
> copy_to_user() return value
> 
> 
> Check copy_to_user() return value in 
> drivers/scsi/megaraid.c::megadev_ioctl()
> This gets rid of this little warning:
>   drivers/scsi/megaraid.c:3661: warning: ignoring return 
> value of 'copy_to_user', declared with attribute warn_unused_result
> 
> 
> Signed-off-by: Jesper Juhl <jesper.juhl@...il.com>
> ---
> 
>  drivers/scsi/megaraid.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> --- linux-2.6.18-rc7-git1-orig/drivers/scsi/megaraid.c	
> 2006-09-15 13:51:15.121774000 +0200
> +++ linux-2.6.18-rc7-git1/drivers/scsi/megaraid.c	
> 2006-09-15 14:27:32.377407763 +0200
> @@ -3658,8 +3658,9 @@ megadev_ioctl(struct inode *inode, struc
>  			 * Send the request sense data also, 
> irrespective of
>  			 * whether the user has asked for it or not.
>  			 */
> -			copy_to_user(upthru->reqsensearea,
> -					pthru->reqsensearea, 14);
> +			if (copy_to_user(upthru->reqsensearea,
> +					pthru->reqsensearea, 14))
> +				rval = -EFAULT;
>  
>  freemem_and_return:
>  			if( pthru->dataxferlen ) {
> 
> 
> 
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/