linux-kernel - Re: [PATCH 5/7] Alter get_order() so that it can make use of ilog2() on a constant [try #3]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <23843.1158656897@warthog.cambridge.redhat.com>
Date:	Tue, 19 Sep 2006 10:08:17 +0100
From:	David Howells <dhowells@...hat.com>
To:	Andrew Morton <akpm@...l.org>
Cc:	David Howells <dhowells@...hat.com>, torvalds@...l.org,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org
Subject: Re: [PATCH 5/7] Alter get_order() so that it can make use of ilog2() on a constant [try #3] 

Andrew Morton <akpm@...l.org> wrote:

> This breaks ia64:

Okay, drop it for now.

> But for some reason putting ARCH_HAS_GET_ORDER into
> include/asm-ia64/bitops.h and including linux/log2.h in
> include/asm-ia64/page.h doesn't fix it.

Seems I need to get an IA64 cross-compiler.

> I didn't pursue it further, because sprinkling ARCH_HAS_FOO things into
> bitops.h(!) is all rather hacky.  Better to use CONFIG_* so they're always
> visible and one knows where to go to find things.

But (1) they're not config options, and (2) there's plenty of precedent for
this sort of thing (ARCH_HAS_PREFETCH for example).

David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/