lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20060920163652.GF30550@redhat.com>
Date:	Wed, 20 Sep 2006 12:36:52 -0400
From:	Dave Jones <davej@...hat.com>
To:	Pekka Enberg <penberg@...helsinki.fi>
Cc:	Andrew Morton <akpm@...l.org>, Alex Dubov <oakad@...oo.com>,
	linux-kernel@...r.kernel.org, drzeus-list@...eus.cx,
	rmk+lkml@....linux.org.uk
Subject: Re: [PATCH 1/2] [MMC] Driver for TI FlashMedia card reader - source

On Wed, Sep 20, 2006 at 09:28:05AM +0300, Pekka Enberg wrote:
 > On 9/20/06, Andrew Morton <akpm@...l.org> wrote:
 > > Trivia:
 > 
 > [snip]
 > 
 > More trivia:
 > 
 >   - Unnecessary casts for void pointers
 >   - Assignment in if statement expression

also

+#include <linux/config.h>
+#include <linux/module.h>
+#include <linux/kernel.h>

Some unnecessary includes there. (config.h & kernel.h are auto-included)

	Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ