linux-kernel - Re: [PATCH 1/2] [MMC] Driver for TI FlashMedia card reader

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060921025106.61978.qmail@web36707.mail.mud.yahoo.com>
Date:	Wed, 20 Sep 2006 19:51:06 -0700 (PDT)
From:	Alex Dubov <oakad@...oo.com>
To:	Andrew Morton <akpm@...l.org>
Cc:	linux-kernel@...r.kernel.org, drzeus-list@...eus.cx,
	rmk+lkml@....linux.org.uk
Subject: Re: [PATCH 1/2] [MMC] Driver for TI FlashMedia card reader - source

> Could I ask where the information which permitted this (nice-looking) driver to
> be written came from?

I had 3 sources for this:
1. win64 binary driver
2. linux binary driver - it says its license is GPL, but source is nowhere to be found
3. OMAP 5912 datasheet for part of the tifm_sd functionality

My upcoming memorystick driver only draws from the first two sources. I should also add that I
never worked for TI nor Everest Consulting (the authors of the binary driver) and don't know
anybody who ever did.

> The driver has lots of really big inlined functions.  It's best to uninline
> these.  If the function has a single callsite, gcc will inline it anyway. 
> If the function has multiple callsites (now, or in the future), inlining it
> is undesirable.

I actually marked them "inline" to signify the fact that only one callsite is intended for these
functions. They are not intended to be called from arbitrary places (no problem to fix those,
though).

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/