linux-kernel - Re: [patch] do_no

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <451170B9.4010101@sgi.com>
Date:	Wed, 20 Sep 2006 18:47:53 +0200
From:	Jes Sorensen <jes@....com>
To:	"Randy.Dunlap" <rdunlap@...otime.net>
Cc:	Linus Torvalds <torvalds@...l.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	bjorn_helgaas@...com, Nick Piggin <nickpiggin@...oo.com.au>,
	Andrew Morton <akpm@...l.org>, Robin Holt <holt@....com>,
	Dean Nelson <dcn@....com>, Hugh Dickins <hugh@...itas.com>
Subject: Re: [patch] do_no_pfn()

Randy.Dunlap wrote:
> On 20 Sep 2006 03:25:25 -0400 Jes Sorensen wrote:
>> +#define NOPFN_SIGBUS	((unsigned long) -1)
>> +#define NOPFN_OOM	((unsigned long) -2)
> 
> Is there any difference in the above and
> 
> #define NOPFN_SIGBUS		-1UL
> #define NOPFN_OOM		-2UL

I don't think there is, but I was trying to keep it consistent with the
NOPAGE_foo versions - the way it's done is more explicit so less likely
anyone will get confused over it.

I can change it if it's a sticking point, but I'd claim thats more noise
than it's worth.

Thanks,
Jes

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/