linux-kernel - Re: 2.6.18-rt1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1158783590.29177.19.camel@c-67-180-230-165.hsd1.ca.comcast.net>
Date:	Wed, 20 Sep 2006 13:19:49 -0700
From:	Daniel Walker <dwalker@...sta.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Gene Heskett <gene.heskett@...izon.net>,
	linux-kernel@...r.kernel.org, paulmck@...ibm.com,
	Thomas Gleixner <tglx@...utronix.de>,
	John Stultz <johnstul@...ibm.com>,
	Dipankar Sarma <dipankar@...ibm.com>,
	Arjan van de Ven <arjan@...radead.org>
Subject: Re: 2.6.18-rt1

On Wed, 2006-09-20 at 21:46 +0200, Ingo Molnar wrote:
> * Gene Heskett <gene.heskett@...izon.net> wrote:
> 
> > That looks like the chorus of the song I saw when it crashed on boot, 
> > pretty darned close to identical.
> 
> ok, i've uploaded -rt3:
> 
>    http://redhat.com/~mingo/realtime-preempt/
> 
> this should have this one fixed.
> 
> 	Ingo

What about the !PREEMPT_RT case.. It still wouldn't disable interrupts
in the below.. 

 
-       local_irq_save(flags);
        if (up->port.sysrq) {
                /* serial8250_handle_port() already took the lock */
                locked = 0;
        } else if (oops_in_progress) {
-               locked = spin_trylock(&up->port.lock);
+               locked = spin_trylock_irqsave(&up->port.lock, flags);
        } else
-               spin_lock(&up->port.lock);
+               spin_lock_irqsave(&up->port.lock, flags);
 


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/