linux-kernel - Re: 2.6.18-rt1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060920201450.GA22482@elte.hu>
Date:	Wed, 20 Sep 2006 22:14:50 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Daniel Walker <dwalker@...sta.com>
Cc:	Gene Heskett <gene.heskett@...izon.net>,
	linux-kernel@...r.kernel.org, paulmck@...ibm.com,
	Thomas Gleixner <tglx@...utronix.de>,
	John Stultz <johnstul@...ibm.com>,
	Dipankar Sarma <dipankar@...ibm.com>,
	Arjan van de Ven <arjan@...radead.org>
Subject: Re: 2.6.18-rt1


* Daniel Walker <dwalker@...sta.com> wrote:

> What about the !PREEMPT_RT case.. It still wouldn't disable interrupts 
> in the below..
>
> -       local_irq_save(flags);
>         if (up->port.sysrq) {
>                 /* serial8250_handle_port() already took the lock */
>                 locked = 0;
>         } else if (oops_in_progress) {
> -               locked = spin_trylock(&up->port.lock);
> +               locked = spin_trylock_irqsave(&up->port.lock, flags);
>         } else
> -               spin_lock(&up->port.lock);
> +               spin_lock_irqsave(&up->port.lock, flags);

_irqsave disables interrupts, always did.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/