linux-kernel - Re: [PATCH]: Fix ALIGN() macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <0C3FEC03-29A8-49B0-9D12-BBFA4AE99A78@mac.com>
Date:	Sat, 23 Sep 2006 16:36:33 -0400
From:	Kyle Moffett <mrmacman_g4@....com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	David Miller <davem@...emloft.net>, linux-kernel@...r.kernel.org,
	torvalds@...l.org
Subject: Re: [PATCH]: Fix ALIGN() macro

On Sep 23, 2006, at 10:40:41, Herbert Xu wrote:
> diff --git a/crypto/hmac.c b/crypto/hmac.c
> index f403b69..d52b234 100644
> --- a/crypto/hmac.c
> +++ b/crypto/hmac.c
> @@ -98,7 +98,7 @@ static int hmac_init(struct hash_desc *p
>  	sg_set_buf(&tmp, ipad, bs);
>
>  	return unlikely(crypto_hash_init(&desc)) ?:
> -	       crypto_hash_update(&desc, &tmp, 1);
> +	       crypto_hash_update(&desc, &tmp, bs);
>  }
>
>  static int hmac_update(struct hash_desc *pdesc,

Quick question:  does "crypto_hash_init()" ever return anything other  
than 0 or 1?  If so this is a subtle bug, as "unlikely()" is  
implemented like this:

# define unlikely(x) __builtin_expect(!!(x), 0)

IMO any usage of likely/unlikely other than if(unlikely()), if(likely 
()) is probably a bug.

Cheers,
Kyle Moffett

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/