linux-kernel - Re: [PATCH]: Fix ALIGN() macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 23 Sep 2006 13:12:52 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	linux-kernel@...r.kernel.org, torvalds@...l.org
Subject: Re: [PATCH]: Fix ALIGN() macro

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Sun, 24 Sep 2006 00:40:41 +1000

> OK I think I've found the problem.
> 
> [CRYPTO] hmac: Fix hmac_init update call
> 
> The crypto_hash_update call in hmac_init gave the number 1
> instead of the length of the sg list in bytes.  This is a
> missed conversion from the digest => hash change.
> 
> As tcrypt only tests crypto_hash_digest it didn't catch this.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

This, along with the ALIGN() patch, fixes all the regressions
for me.  Good spotting Herbert!

Linus, please apply.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/