linux-kernel - Re: NV SATA breakage: jgarzik/libata-dev#upstream etc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <451721F8.4060600@pobox.com>
Date:	Sun, 24 Sep 2006 20:25:28 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Krzysztof Halasa <khc@...waw.pl>
CC:	Tejun Heo <htejun@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: NV SATA breakage: jgarzik/libata-dev#upstream etc

Krzysztof Halasa wrote:
> Hi,
> 
> The following commit in libata-dev breaks NV SATA init - I don't
> have a dump handy, but the problem is a NULL ptr dereference here:
> 
> libata-core.c
> int ata_device_add(const struct ata_probe_ent *ent)
> {
> ...
>         /* register each port bound to this device */
>         for (i = 0; i < host->n_ports; i++) {
> ...
>                 /* start port */
>                 rc = ap->ops->port_start(ap);
>                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> The problematic commit is fea63e38013ec628ab3f7fddc4c2148064b7910a:
> "[PATCH] libata: fix non-uniform ports handling
> 
> Non-uniform ports handling got broken while updating libata to handle
> those in the same host.  Only separate irq for the non-uniform
> secondary port was implemented while all other fields (host flags,
> transfer mode...) of the secondary port simply shared those of the
> first.

What's broken, and how does it affect NV sata?

That's the chipset on my main dev workstation, and there are no problems 
here...

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/