[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20060927214428.9e5c0e79.akpm@osdl.org>
Date: Wed, 27 Sep 2006 21:44:28 -0700
From: Andrew Morton <akpm@...l.org>
To: Jeff Garzik <jeff@...zik.org>, linux-scsi@...r.kernel.org,
Greg KH <greg@...ah.com>, LKML <linux-kernel@...r.kernel.org>,
Linus Torvalds <torvalds@...l.org>
Subject: Re: [PATCH] Illustration of warning explosion silliness
On Wed, 27 Sep 2006 21:36:28 -0700
Andrew Morton <akpm@...l.org> wrote:
> device_for_each_child()
All that being said, device_for_each_child() is rather broken by design.
It walks a list of items applying a function to them and bales out on
first-error.
There's no way in which the caller can know which items have been operated
on, nor which items have yet to be operated on, nor which item experienced
the failure. Any caller which is serious about error recovery presumably
won't use it, unless the callback function happens to be something which
makes no state changes.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists