linux-kernel - Re: [patch 2/2] libata:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200609291756.k8THuHAc008660@turing-police.cc.vt.edu>
Date:	Fri, 29 Sep 2006 13:56:17 -0400
From:	Valdis.Kletnieks@...edu
To:	Kristen Carlson Accardi <kristen.c.accardi@...el.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
	jgarzik@...ox.com, rdunlap@...otime.net
Subject: Re: [patch 2/2] libata: _SDD support

On Thu, 28 Sep 2006 11:30:43 PDT, Kristen Carlson Accardi said:
> _SDD (Set Device Data) is an ACPI method that is used to tell the 
> firmware what the identify data is of the device that is attached to
> the port.  It is an optional method, and it's ok for it to be missing. 
> Because of this, we always return success from the routine that calls
> this method, even if the execution fails.

I'm OK on it returning success if the _SDD is missing entirely.  And I see
where it's properly droppping a KERN_DEBUG-level printk if it misbehaves.
Whether it should continue on and return success anyhow, I'm not sure.  Can one
of the ACPI wizards comment on that?


Content of type "application/pgp-signature" skipped