linux-kernel - Re: [PATCH] fs/eventpoll: error handling micro-cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <451FE7E3.4050503@garzik.org>
Date:	Sun, 01 Oct 2006 12:08:03 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Davide Libenzi <davidel@...ilserver.org>
CC:	Andrew Morton <akpm@...l.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs/eventpoll: error handling micro-cleanup

Davide Libenzi wrote:
> On Sun, 1 Oct 2006, Jeff Garzik wrote:
> 
>> While reviewing the 'may be used uninitialized' bogus gcc warnings,
>> I noticed that an error code assignment was only needed if an error had
>> actually occured.
> 
> But that saved one line of code, and there are countless occurences in the 
> kernel of such code pattern ;)

I'm not sure there are countless occurrences with PTR_ERR().  The line 
is incorrect (but harmless) if inode is a valid pointer...


> In any case, fine by me and not worth further discussion.

Thanks :)


>> --- a/fs/eventpoll.c
>> +++ b/fs/eventpoll.c
>> @@ -720,9 +720,10 @@ static int ep_getfd(int *efd, struct ino
>>  
>>  	/* Allocates an inode from the eventpoll file system */
>>  	inode = ep_eventpoll_inode();
>> -	error = PTR_ERR(inode);
>> -	if (IS_ERR(inode))
>> +	if (IS_ERR(inode)) {
>> +		error = PTR_ERR(inode);


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/