linux-kernel - Re: [PATCH 2.6.18] pktcdvd driver module: added sysfs interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <op.tgq8k7j9iudtyh@master>
Date:	Sun, 01 Oct 2006 20:37:24 +0200
From:	"Thomas Maier" <balagi@...tmail.de>
To:	"Peter Osterlund" <petero2@...ia.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2.6.18] pktcdvd driver module: added sysfs interface

Hello,

> "Thomas Maier" <balagi@...tmail.de> writes:
>
>> this is a patch for the packet writing module pktcdvd.
>> The patch adds a sysfs and a debugfs interface, a Kconfig
>> parameter to switch of the procfs interface off and a
>> bio write queue congestion handling for the driver.
>
> I think most of these changes are good. However, some comments:
>
> * There are many logically independent parts in this change, so they
>   should be in separate patches. For example:
>   - Introduce the DRIVER_NAME #define.
>   - Add sysfs support.
>   - Make procfs support optional.
>   - Implement congestion control.
>   - Move lots of functions around. (Is it needed at all?)

Oh, this is ugly for coding, since all is in the same file.
But i splitted the patch and will send all 4 parts again.

I moved the functions for grouping and better readability.


> * You need to add Signed-off-by.

Ok.

> * You should CC Andrew Morton and not Linus. These changes should live
>   in -mm for a while before going into the main tree.

Ok, but the changes should not be harmful and easy, i think ;)

> * The patch is white space damaged. All lines that should start with a
>   single space start with two spaces.

Ugly. Thanks for the hit, haven't noticed it.


Thanks

Thomas Maier

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/