| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: 01 Oct 2006 14:47:58 +0200 From: Peter Osterlund <petero2@...ia.com> To: balagi@...tmail.de Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Greg KH" <greg@...ah.com>, torvalds@...l.org, alan@...hat.com Subject: Re: [PATCH 2.6.18] pktcdvd driver module: added sysfs interface "Thomas Maier" <balagi@...tmail.de> writes: > this is a patch for the packet writing module pktcdvd. > The patch adds a sysfs and a debugfs interface, a Kconfig > parameter to switch of the procfs interface off and a > bio write queue congestion handling for the driver. I think most of these changes are good. However, some comments: * There are many logically independent parts in this change, so they should be in separate patches. For example: - Introduce the DRIVER_NAME #define. - Add sysfs support. - Make procfs support optional. - Implement congestion control. - Move lots of functions around. (Is it needed at all?) * You need to add Signed-off-by. * You should CC Andrew Morton and not Linus. These changes should live in -mm for a while before going into the main tree. * The patch is white space damaged. All lines that should start with a single space start with two spaces. -- Peter Osterlund - petero2@...ia.com http://web.telia.com/~u89404340 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists