linux-kernel - Re: [patch 1/2] libata:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20061002094518.4ba56020.kristen.c.accardi@intel.com>
Date:	Mon, 2 Oct 2006 09:45:18 -0700
From:	Kristen Carlson Accardi <kristen.c.accardi@...el.com>
To:	Andrey Borzenkov <arvidjaar@...l.ru>
Cc:	linux-kernel@...r.kernel.org, jgarzik@...ox.com
Subject: Re: [patch 1/2] libata: _GTF support

On Sun, 01 Oct 2006 21:02:21 +0400
Andrey Borzenkov <arvidjaar@...l.ru> wrote:

> Kristen Carlson Accardi wrote:
> 
> > _GTF is an acpi method that is used to reinitialize the drive.  It returns
> > a task file containing ata commands that are sent back to the drive to
> > restore it to boot up defaults.
> > 
> [...]
> > @@ -1597,6 +1601,9 @@ int ata_bus_probe(struct ata_port *ap)
> >  /* reset and determine device classes */
> >  ap->ops->phy_reset(ap);
> >  
> > +     /* retrieve and execute the ATA task file of _GTF */
> > +     ata_acpi_exec_tfs(ap);
> > +
> >  for (i = 0; i < ATA_MAX_DEVICES; i++) {
> >  dev = &ap->device[i];
> >
> 
> ata_bus_probe() seems to be called only if driver does not provide own error
> handler? Also would GTF be executed on resume? I hoped it may fix resume
> from RAM problem I have but it looks like this is never executed in my case
> (pata_ali).
> 
> TIA
> 
> -andrey

Hi Andrey
On Friday I submitted another patch which changes where this is executed.
http://marc.theaimsgroup.com/?l=linux-ide&m=115957671114738&w=2

Hopefully this will work better for you.

Kristen
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/