linux-kernel - Re: [PATCH 0/6]: powerpc/cell spidernet ethernet patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200610021850.41062.arnd@arndb.de>
Date:	Mon, 2 Oct 2006 18:50:39 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Linas Vepstas <linas@...tin.ibm.com>
Cc:	linuxppc-dev@...abs.org, jeff@...zik.org, akpm@...l.org,
	netdev@...r.kernel.org, James K Lewis <jklewis@...ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/6]: powerpc/cell spidernet ethernet patches

On Monday 02 October 2006 18:27, Linas Vepstas wrote:
> > 
> > I'm not sure if I have missed a patch in here, but I
> > don't see anything reintroducing the 'netif_stop_queue'
> > that is missing from the transmit path.
> > 
> > Do you have a extra patch for that?
> 
> Unfinished.  There are several ways in which the current 
> spider-net driver doesn't do things the way Greg KH's, etal 
> book on device drivers recommends. I was planning on combing 
> through these this week.

Ok, that's good. However, removing the netif_stop_queue
was an obvious oversight that happened during the cleanup
last year.

Putting that one line back in should be a really safe fix for
the problem of overly high system load we sometimes see.

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/