linux-kernel - Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0610021729490.8219-100000@iolanthe.rowland.org>
Date:	Mon, 2 Oct 2006 17:34:40 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	David Brownell <david-b@...bell.net>
cc:	Andrew Morton <akpm@...l.org>, David Howells <dhowells@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>, <torvalds@...l.org>,
	<linux-kernel@...r.kernel.org>, <linux-arch@...r.kernel.org>,
	Dmitry Torokhov <dtor@...l.ru>, Greg KH <greg@...ah.com>
Subject: Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than
 passing to IRQ handlers

On Mon, 2 Oct 2006, David Brownell wrote:

> > >  (*) finish_unlinks() in drivers/usb/host/ohci-q.c needs checking.  It does
> > >      something different depending on whether it's been supplied with a regs
> > >      pointer or not.
> 
> gaak!  where did that come from?  I'll be surprised if removing
> that causes any problem at all.

Here's the statement in question:

	if (likely (regs && HC_IS_RUNNING(ohci_to_hcd(ohci)->state))) {
		...

Notice another questionable use of hcd->state.  I don't know what the 
correct change here is, but I suspect David H's isn't optimal.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/