linux-kernel - Re: [patch] call truncate_inode_pages in the DIO fallback to buffered I/O path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4523F486.1000604@oracle.com>
Date:	Wed, 04 Oct 2006 10:51:02 -0700
From:	Zach Brown <zach.brown@...cle.com>
To:	Andrew Morton <akpm@...l.org>
CC:	Jeff Moyer <jmoyer@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [patch] call truncate_inode_pages in the DIO fallback to buffered
 I/O path

> Why is this a problem?  It's just like someone did a write(), and we'll
> invalidate the pagecache on the next direct-io operation.

This was noticed as a distro regression as they moved from the kernels
that used to invalidate the entire address space on direct io ops to
more modern ones that only invalidate the region being written.

You can end up with significant memory pressure after this change with a
large enough working set on disk.

> eek.  truncate_inode_pages() will throw away dirty data.  Very dangerous,
> much chin-scratching needed.

Yeah, I failed to tell Jeff that it should be calling
filemap_fdatawrite() first to get things into writeback.  (And
presumably not truncating if that returns an error.)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/