linux-kernel - Re: wpa supplicant/ipw3945, ESSID last char missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0610041216510.3952@g5.osdl.org>
Date:	Wed, 4 Oct 2006 12:21:46 -0700 (PDT)
From:	Linus Torvalds <torvalds@...l.org>
To:	Jean Tourrilhes <jt@....hp.com>
cc:	"John W. Linville" <linville@...driver.com>,
	Jeff Garzik <jeff@...zik.org>,
	Lee Revell <rlrevell@...-job.com>,
	Alessandro Suardi <alessandro.suardi@...il.com>,
	Norbert Preining <preining@...ic.at>,
	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org,
	johannes@...solutions.net
Subject: Re: wpa supplicant/ipw3945, ESSID last char missing

On Wed, 4 Oct 2006, Jean Tourrilhes wrote:
> > 
> > It's not what we have ever done. We've _extended_ the API. But we don't 
> > break old ones.
> 
> 	Old APIs get deprecated, and people are forced to the new API,
> which is exactly the same as far as userspace is concerned. This
> transition is exactly the same as what you propose, both kernel API
> coexist for some time, except it happens in userspace instead of in
> kernel, which is an implementation detail.
> 	So, my question is when can I remove the old ESSID API.

That isn't the question here. 

The current situation seems to be designed to add the new one and removing 
the old one as a single step. THAT IS BROKEN.

The new one and the old one needs to work at the same time, exactly so 
that there's a transition mechanism.

That's the part you seem to now have understood. There should be no "flag 
day" when people have to switch over.

> 	The Wireless people (Jouni, Dan) decided to change the
> *userspace* API. We could translate the new *userspace* API to the old
> kernel API, but I don't see the point.

You do not indeed see the point.

The point is, we can switch internal kernel ABI's - new or old - at any 
point. But user-level ABI's should never require a one-way update.

> 	That's exactly what it hinges on. What is your criteria for
> removing the old ESSID API. My understanding was 6 months.

But we didn't have 6 months of the new API, did we? People complained. 

The person you merged through explicitly said that if he had realized what 
you did, he wouldn't have merged.

That should tell you something. Why are you ignoring this?

			Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/