[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1160042489.3101.2.camel@alice>
Date: Thu, 05 Oct 2006 12:01:29 +0200
From: Eric Sesterhenn <snakebyte@....de>
To: linux-kernel@...r.kernel.org
Cc: netwiz@....id.au
Subject: [Patch] Dereference in drivers/usb/misc/adutux.c
hi,
in two of the error cases, dev is still NULL,
and we dereference it. Spotted by coverity (cid#1428, 1429)
Signed-off-by: Eric Sesterhenn <snakebyte@....de>
--- linux-2.6.19-rc1/drivers/usb/misc/adutux.c.orig 2006-10-05 11:57:52.000000000 +0200
+++ linux-2.6.19-rc1/drivers/usb/misc/adutux.c 2006-10-05 11:58:19.000000000 +0200
@@ -370,7 +370,8 @@ static int adu_release(struct inode *ino
retval = adu_release_internal(dev);
exit:
- up(&dev->sem);
+ if(dev)
+ up(&dev->sem);
dbg(2," %s : leave, return value %d", __FUNCTION__, retval);
return retval;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists