linux-kernel - Re: [Patch] Dereference in drivers/usb/misc/adutux.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20061005082131.c9a0ecd0.rdunlap@xenotime.net>
Date:	Thu, 5 Oct 2006 08:21:31 -0700
From:	Randy Dunlap <rdunlap@...otime.net>
To:	Eric Sesterhenn <snakebyte@....de>
Cc:	linux-kernel@...r.kernel.org, netwiz@....id.au
Subject: Re: [Patch] Dereference in drivers/usb/misc/adutux.c

On Thu, 05 Oct 2006 12:01:29 +0200 Eric Sesterhenn wrote:

> hi,
> 
> in two of the error cases, dev is still NULL,
> and we dereference it. Spotted by coverity (cid#1428, 1429)
> 
> Signed-off-by: Eric Sesterhenn <snakebyte@....de>
> 
> --- linux-2.6.19-rc1/drivers/usb/misc/adutux.c.orig	2006-10-05 11:57:52.000000000 +0200
> +++ linux-2.6.19-rc1/drivers/usb/misc/adutux.c	2006-10-05 11:58:19.000000000 +0200
> @@ -370,7 +370,8 @@ static int adu_release(struct inode *ino
>  	retval = adu_release_internal(dev);
>  
>  exit:
> -	up(&dev->sem);
> +	if(dev)
> +		up(&dev->sem);
>  	dbg(2," %s : leave, return value %d", __FUNCTION__, retval);
>  	return retval;
>  }

	if (dev)

space after if, for, while, etc.  No space after function names.

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/