linux-kernel - Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45266523.9040408@garzik.org>
Date:	Fri, 06 Oct 2006 10:16:03 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	Ingo Molnar <mingo@...e.hu>, Alan Cox <alan@...rguk.ukuu.org.uk>,
	David Howells <dhowells@...hat.com>,
	Andrew Morton <akpm@...l.org>,
	Thomas Gleixner <tglx@...utronix.de>, torvalds@...l.org,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	Greg KH <greg@...ah.com>, David Brownell <david-b@...bell.net>,
	Alan Stern <stern@...land.harvard.edu>
Subject: Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing
 to IRQ handlers

Dmitry Torokhov wrote:
> On 10/6/06, Ingo Molnar <mingo@...e.hu> wrote:
>>
>> * Jeff Garzik <jeff@...zik.org> wrote:
>>
>> > >but pt_regs is alot less frequently used than irq - and where it's
>> > >used they arent "drivers" but mostly arch level code like hw-timer
>> > >handlers.
>> >
>> > Nonetheless the -vast majority- of drivers don't use the argument at
>> > all, and the minority that do use it are not modern drivers.
>>
>> i'm all for changing that too :)
>>
> 
> What drivers use irq argument? I know i8042 does but only to detect
> whether interrupt routine was called because irq was raised or it was
> called manually and I can use dev_id for that...

Ancient ISA legacys, a few powermac drivers, and a lot of printk's. 
Your gut instinct is correct -- outside of printk, it is largely used to 
differentiate callers.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/