linux-kernel - [RFC] Fix check_partition routines ( was Re: [RFC] PATCH to fix rescan_partitions to return errors properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <452706EA.3040702@in.ibm.com>
Date:	Fri, 06 Oct 2006 18:46:18 -0700
From:	Suzuki K P <suzuki@...ibm.com>
To:	Erik Mouw <erik@...ddisk-recovery.com>
CC:	lkml <linux-kernel@...r.kernel.org>, linux-fsdevel@...r.kernel.org,
	Andrew Morton <akpm@...l.org>, andmike@...ibm.com
Subject: [RFC] Fix check_partition routines ( was Re: [RFC] PATCH to fix rescan_partitions
 to return errors properly - take 2)

Hi,


Here is a followup patch, which cleans up the check_partition() as well 
as some of the partition check routines.

check_partition would now record the I/O error notice and proceed with 
the other partitions. The error will only be reported when all of the 
partitions have left the disk as "Unknown".

Cleanup for partition checkers for ibm, atari and amiga.

Comments ?

Thanks

Suzuki


Erik Mouw wrote:
> On Fri, Oct 06, 2006 at 10:43:42AM -0700, Suzuki K P wrote:
> 
>>Erik Mouw wrote:
>>
>>>I think it's best not to change the current behaviour and let all
>>>partition checkers run, even if one of them failed due to device
>>>errors. I wouldn't mind if the behaviour changed like you propose,
>>>though.
>>>
>>
>>At present, the partition checkers doesn't run, if one of the preceeding 
>>checker has reported an error ! *But*, some of the checkers doesn't 
>>report the I/O error which they came across! So, this may let others 
>>run. Thats not we want, right. We would like them to return I/O errors, 
>>and and the check_partition should let other partition checkers continue.
> 
> 
> Indeed, we want them to behave the same. I.e.: a partition checker
> should tell when it encounters an I/O error.
> 
> 
> Erik
> 



View attachment "fix-check_partition-methods.diff" of type "text/x-patch" (4759 bytes)