linux-kernel - Re: [RFC] Fix check_partition routines ( was Re: [RFC] PATCH to fix rescan_partitions to return errors properly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20061006194550.8351ed5e.akpm@osdl.org>
Date:	Fri, 6 Oct 2006 19:45:50 -0700
From:	Andrew Morton <akpm@...l.org>
To:	Suzuki K P <suzuki@...ibm.com>
Cc:	Erik Mouw <erik@...ddisk-recovery.com>,
	lkml <linux-kernel@...r.kernel.org>,
	linux-fsdevel@...r.kernel.org, andmike@...ibm.com
Subject: Re: [RFC] Fix check_partition routines ( was Re: [RFC] PATCH to fix
 rescan_partitions to return errors properly - take 2)

On Fri, 06 Oct 2006 18:46:18 -0700
Suzuki K P <suzuki@...ibm.com> wrote:

> *  The check_partition() stops its probe once it hits an I/O error from the partition checkers. This would prevent the actual partition checker getting a chance to verify the partition. So, this patch lets the check_partition continue probing untill it hits a success while recording the I/O error which might have been reported by the checking routines.
> 
> Also, it does some cleanup of the partition methods for ibm, atari and amiga to return -1 upon hitting an I/O error.

What is the significance of a `return 1', a `return 0' and a `return -EFOO' in these
functions?  It all looks rather odd.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/