linux-kernel - Re: [PATCH 1/2] crypto: fix crypto_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20061009115526.GA10857@localhost>
Date:	Mon, 9 Oct 2006 20:55:26 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 1/2] crypto: fix crypto_alloc_{tfm,base}() return value

On Mon, Oct 09, 2006 at 09:14:46PM +1000, Herbert Xu wrote:

> Actually, crypto_alloc_tfm is an obsolete function which is supposed
> to maintain its previous semantics of returning NULL or success.

I misunderstood about crypto_alloc_tfm().

BTW, ecryptfs and reiser4 are still using crypto_alloc_tfm().
Should we mark it as __deprecated?

> I don't quite see where the problem with crypto_alloc_base is.

- __crypto_alloc_tfm() should return -ENOMEM on kzalloc() failure.
  But it returns NULL.

- crypto_alloc_base() may not return -EINTR on signal_pending()

I'll fix the patch and resend with more clear description later.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/